Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoadTest] Revamp load test suite #1002

Merged
merged 18 commits into from
Jan 10, 2025
Merged

[LoadTest] Revamp load test suite #1002

merged 18 commits into from
Jan 10, 2025

Conversation

red-0ne
Copy link
Contributor

@red-0ne red-0ne commented Dec 11, 2024

Summary

This pull request includes several updates to the load-testing configuration and test files, as well as improvements to the relay stress test suite. The most important changes include updating funding account addresses, modifying gateway configurations, and refactoring various test functions for better accuracy.

Type of change

Select one or more from the following:

Testing

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@red-0ne red-0ne added the loadtest Work related to load testing label Dec 11, 2024
@red-0ne red-0ne added this to the Shannon Beta TestNet Support milestone Dec 11, 2024
@red-0ne red-0ne requested a review from okdas December 11, 2024 16:59
@red-0ne red-0ne self-assigned this Dec 11, 2024
@Olshansk
Copy link
Member

@red-0ne Lmk if you need me to take a look at this as well.

@red-0ne red-0ne marked this pull request as ready for review December 17, 2024 12:47
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@red-0ne Partial review.

This is great work but load-testing/tests/relays_stress_helpers_test.go is really hard to review right now with lots of big inline functions.

Do you mind doing a self passthrough and finding ways to make it a bit more readable & maintainable for others?

load-testing/loadtest_manifest_example.yaml Outdated Show resolved Hide resolved
load-testing/loadtest_manifest_example.yaml Show resolved Hide resolved
load-testing/loadtest_manifest_localnet.yaml Outdated Show resolved Hide resolved
load-testing/loadtest_manifest_localnet.yaml Show resolved Hide resolved
load-testing/tests/relays_stress.feature Show resolved Hide resolved
load-testing/tests/relays_stress_helpers_test.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_helpers_test.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_helpers_test.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_helpers_test.go Outdated Show resolved Hide resolved
@red-0ne
Copy link
Contributor Author

red-0ne commented Jan 3, 2025

@red-0ne Partial review.

This is great work but load-testing/tests/relays_stress_helpers_test.go is really hard to review right now with lots of big inline functions.

Do you mind doing a self passthrough and finding ways to make it a bit more readable & maintainable for others?

It is indeed very hard to follow, we have a TODO_TECHDEBT where we'll have to address this particular issue:

image

Will create an issue and prioritize accordingly.

@red-0ne red-0ne requested a review from Olshansk January 3, 2025 15:57
load-testing/tests/relays_stress_helpers_test.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_helpers_test.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_helpers_test.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_single_supplier.feature Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_single_supplier.feature Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_test.go Show resolved Hide resolved
@red-0ne red-0ne requested a review from Olshansk January 7, 2025 04:41
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor NITs but lets get it in afterwards!

load-testing/tests/relays_stress_test.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_test.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_test.go Show resolved Hide resolved
load-testing/tests/relays_stress_test.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_test.go Show resolved Hide resolved
testutil/delays/waitall.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_helpers_test.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_helpers_test.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_helpers_test.go Outdated Show resolved Hide resolved
load-testing/tests/relays_stress_helpers_test.go Outdated Show resolved Hide resolved
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 1002)
Grafana network dashboard for devnet-issue-1002

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Jan 10, 2025
@red-0ne red-0ne merged commit 6680d3e into main Jan 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet devnet-test-e2e loadtest Work related to load testing push-image CI related - pushes images to ghcr.io
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants